Skip to content

RichText: remove obsolete rule from stylesheet #13871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2019
Merged

RichText: remove obsolete rule from stylesheet #13871

merged 1 commit into from
Feb 14, 2019

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Feb 14, 2019 •
edited
Loading

Description

Removes the p:empty rule. There's no way it can ever be empty. It's always padded with a <br> element. I believe this is a remnant from the early TinyMCE days when we didn't have a rich text state yet. There would be cases were TinyMCE wouldn't pad with a <br> element. Now this is impossible.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@ellatrix ellatrix changed the title Fix/rich text styles RichText: remove obsolete rule from stylesheet Feb 14, 2019
@ellatrix ellatrix force-pushed the fix/rich-text-styles branch from c1d2f03 to 59f1ef0 Compare February 14, 2019 09:06
jorgefilipecosta
jorgefilipecosta approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
I verified empty rich texts contain <br data-rich-text-padding="true"> so this rule is never used as described.

@jorgefilipecosta jorgefilipecosta added [Type] Enhancement A suggestion for improvement. [Type] Code Quality Issues or PRs that relate to code quality labels Feb 14, 2019
@ellatrix ellatrix merged commit c6255ed into master Feb 14, 2019
@ellatrix ellatrix deleted the fix/rich-text-styles branch February 14, 2019 10:14
@youknowriad youknowriad added this to the 5.1 (Gutenberg) milestone Feb 15, 2019
This was referenced Feb 18, 2019
Merged
Merged
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@ellatrix @youknowriad
RichText: remove obsolete rule from stylesheet (#13871)
0fd8c20
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@ellatrix @youknowriad
RichText: remove obsolete rule from stylesheet (#13871)
fd1c9fa
This was referenced Apr 30, 2020
Closed
Closed
Merged
Merged
Merged
Closed
Closed
This was referenced May 1, 2020
Closed
Closed
Merged
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@aduth aduth Awaiting requested review from aduth

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@gziolo gziolo Awaiting requested review from gziolo

@nerrad nerrad Awaiting requested review from nerrad

@oandregal oandregal Awaiting requested review from oandregal

@ntwb ntwb Awaiting requested review from ntwb

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
[Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
5.1 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
3 participants
@ellatrix @jorgefilipecosta @youknowriad