Skip to content

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Feb 7, 2019

Description

This is a small PR to remove the option to edit sizes in Image Blocks.

I also took the opportunity to organize import statements in image/edit.native.js.

screen shot 2019-02-07 at 9 58 20 pm

To test:

  • Check out the related gutenberg-mobile branch and run the app.
  • Add an image block and add an image to it.
  • Open the image settings.
  • Check that the Image Size option is not there.

Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@etoledom
Copy link
Contributor Author

Thank you!

@etoledom etoledom merged commit 1c583b2 into master Feb 11, 2019
@etoledom etoledom deleted the rnmobile/remove-size-settings branch February 11, 2019 16:19
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
* Mobile: Remove Size Setting from Image Block.

* Organizing imports on mobile ImageEdit

* Fix lint issues
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
* Mobile: Remove Size Setting from Image Block.

* Organizing imports on mobile ImageEdit

* Fix lint issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants