Skip to content

Conversation

oandregal
Copy link
Member

This PR fixes an error with the ./bin/setup-environment.sh command by setting the wp-settings.php permissions to something wp-cli core update won't complain about.

Description

Upon exectuion, I've got the following error:

The update cannot be installed because we will be unable to copy some files. This is usually due to inconsistent file permissions.: wp-settings.php

screenshot from 2019-01-25 11-21-46

It looks like the WordPress core update can't proceed due to wp-settings.php permissions.

Test

Executing the command and check that it's able to upgrade to latest WordPress.

I've done this by trying a fresh start (removed docker images and containers, cloned repo, and executed ./bin/setup-environment.sh command), but if you have a WordPress version < 5.0.3 as the offending line is the core update command.

@oandregal oandregal requested a review from a team January 28, 2019 14:21
@oandregal oandregal self-assigned this Jan 28, 2019
@oandregal oandregal added the [Type] Build Tooling Issues or PRs related to build tooling label Jan 28, 2019
@oandregal oandregal added this to the 5.0 (Gutenberg) milestone Jan 28, 2019
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works for me 👍

@gziolo
Copy link
Member

gziolo commented Jan 28, 2019

Yes, it should be okey. I hope we find a bit better way to set permissions for all files in the long run. I personally did the same tweak a few weeks back 😅

@oandregal oandregal merged commit 190ce7f into master Jan 29, 2019
@oandregal oandregal deleted the fix/wp-settings-permissions branch January 29, 2019 09:14
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants