Skip to content

RSS block: excerpt length label #13501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2019
Merged

RSS block: excerpt length label #13501

merged 1 commit into from
Jan 25, 2019

Conversation

Soean
Copy link
Member

@Soean Soean commented Jan 25, 2019

Description

Changes the label of max word length setting in the RSS block.

From Max length of the excerpt to Max number of words in excerpt

Before:
bildschirmfoto 2019-01-25 um 11 58 07

After:
bildschirmfoto 2019-01-25 um 12 00 54

Part of this issue collection: #13498

@Soean Soean added [Type] Copy Issues or PRs that need copy editing assistance [Block] RSS Affects the RSS Block - used to display entries from an RSS/Atom feed labels Jan 25, 2019
@gziolo gziolo mentioned this pull request Jan 25, 2019
Open
5 tasks
@Soean Soean changed the title Change RSS excerpt length label RSS block: excerpt length label Jan 25, 2019
@gziolo gziolo added this to the 5.0 (Gutenberg) milestone Jan 25, 2019
gziolo
gziolo approved these changes Jan 25, 2019
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code 👍

I hope we get also copy confirmation from someone who previously worked on PRs with copy updates:

@michelleweber, @samikeijonen or @dimadin?

We are also seeking for help with reviewing all translations added to the new RSS block.

@gziolo gziolo added the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Jan 25, 2019
@michelleweber
Copy link

Looks good!

@gziolo gziolo merged commit 2b49f1e into master Jan 25, 2019
@gziolo gziolo deleted the update/rss-word-length branch January 25, 2019 12:20
@gziolo
Copy link
Member

gziolo commented Jan 25, 2019

Thanks, @michelleweber for very quick feedback, much appreciated 🙇

@samikeijonen
Copy link
Contributor

+1 from me.

This was referenced Feb 4, 2019
Merged
Closed
Merged
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@Soean @youknowriad
Change RSS excerpt length label (#13501)
521805b
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@Soean @youknowriad
Change RSS excerpt length label (#13501)
aecaa67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

Assignees
No one assigned
Labels
[Block] RSS Affects the RSS Block - used to display entries from an RSS/Atom feed Needs Copy Review Needs review of user-facing copy (language, phrasing) [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Milestone
5.0 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
4 participants
@Soean @michelleweber @gziolo @samikeijonen