Skip to content

Conversation

Soean
Copy link
Member

@Soean Soean commented Jan 22, 2019

Description

The custom class should only be added to the wrapper, not every div
Fixes #13430

@Soean Soean added the [Block] File Affects the File Block label Jan 22, 2019
@jorgefilipecosta jorgefilipecosta self-requested a review January 23, 2019 13:03
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the problem in my tests and the change makes sense 👍

@jorgefilipecosta jorgefilipecosta merged commit 22abc9e into master Jan 23, 2019
@jorgefilipecosta jorgefilipecosta deleted the fix/file-classname branch January 23, 2019 13:13
@Soean Soean added this to the 5.0 (Gutenberg) milestone Jan 23, 2019
daniloercoli added a commit that referenced this pull request Jan 24, 2019
…rnmobile/372-add-title-to-gutenberg-mobile

* 'master' of https://github.com/WordPress/gutenberg: (56 commits)
  Save package-lock.json file changes (#13481)
  Plugin: Deprecate gutenberg_add_responsive_body_class (#13461)
  Add speak messages to the feature toggle component. (#13385)
  Plugin: Deprecate gutenberg_kses_allowedtags (#13460)
  Plugin: Deprecate gutenberg_bulk_post_updated_messages (#13472)
  Plugin: Avoid calling deprecated gutenberg_silence_rest_errors (#13446)
  Plugin: Deprecate gutenberg_remove_wpcom_markdown_support (#13473)
  Fix: Categories block: add custom classes only to wrapper (#13439)
  is-shallow-equal: Use ES5 ruleset from eslint-plugin module (#13428)
  Update and Organize Contributors Guide per #12916 (#13352)
  Dismissible-notices: fix text overlapping icon (X) (#13371)
  Framework: Remove 5.0-merged REST API integrations (#13408)
  Plugin: Remove 5.0-merged block registration functions, integrations (#13412)
  Framework: Bump minimum required WP to 5.x (#13370)
  [Mobile] Improve keyboard hide button (#13415)
  Improve castError handling of non strings (#13315)
  Fix: File block add custom class (#13432)
  Consider making Fullscreen Mode effects visible only on larger screens (#13425)
  Update plugin version to 4.9.0 (#13436)
  DateTimePicker: fix prop warning for (#12933)
  ...
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
## Description
The custom class should only be added to the wrapper, not every div
Fixes #13430
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
## Description
The custom class should only be added to the wrapper, not every div
Fixes #13430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] File Affects the File Block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants