Docs: mention dark colour scheme in design docs #13375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I updated the link to reference GitHub directly. Starting the url with the top folder allows us to do that. This will also work on Gutenberg handbook, it is going to be properly updated by set of regular expression applied behind the scenes :) Saying that, I'm coming to the conclusion that I need to document all those guidelines which emerged when dealing with links. |
gziolo
approved these changes
Jan 22, 2019
|
Thanks for this addition, looks good 👍 |
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Docs: mention dark colour scheme in design docs * Update link
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Docs: mention dark colour scheme in design docs * Update link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a section about dark colour scheme in design docs.
It's easy enough to forget to test with dark backgrounds, just like folks forget to test mobile. Would be great to remind folks to test.
Example what happens when you forget to test: https://github.com/Automattic/wp-calypso/issues/30198
How has this been tested?
—
Types of changes
Checklist: