Dismissible-notices: fix text overlapping icon (X) #13371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
approved these changes
Jan 21, 2019
There was a problem hiding this comment.
Thank you for your changes @Naerriel, things worked great on my tests and it improves the behavior in some resolutions and when resizing.
Before:
After:
|
Pinging to @jasmussen to have a last look regarding the design/CSS change. |
|
Love it. Can we change the 25px to |
|
@Naerriel would you mind applying the change @jasmussen shared so we could merge your first contribution? :) |
|
@jasmussen @gziolo Thank you for feedback and reminding me. :) |
…fix/11156-dismissilbe-notices
gziolo
approved these changes
Jan 23, 2019
daniloercoli
added a commit
that referenced
this pull request
Jan 24, 2019
…rnmobile/372-add-title-to-gutenberg-mobile * 'master' of https://github.com/WordPress/gutenberg: (56 commits) Save package-lock.json file changes (#13481) Plugin: Deprecate gutenberg_add_responsive_body_class (#13461) Add speak messages to the feature toggle component. (#13385) Plugin: Deprecate gutenberg_kses_allowedtags (#13460) Plugin: Deprecate gutenberg_bulk_post_updated_messages (#13472) Plugin: Avoid calling deprecated gutenberg_silence_rest_errors (#13446) Plugin: Deprecate gutenberg_remove_wpcom_markdown_support (#13473) Fix: Categories block: add custom classes only to wrapper (#13439) is-shallow-equal: Use ES5 ruleset from eslint-plugin module (#13428) Update and Organize Contributors Guide per #12916 (#13352) Dismissible-notices: fix text overlapping icon (X) (#13371) Framework: Remove 5.0-merged REST API integrations (#13408) Plugin: Remove 5.0-merged block registration functions, integrations (#13412) Framework: Bump minimum required WP to 5.x (#13370) [Mobile] Improve keyboard hide button (#13415) Improve castError handling of non strings (#13315) Fix: File block add custom class (#13432) Consider making Fullscreen Mode effects visible only on larger screens (#13425) Update plugin version to 4.9.0 (#13436) DateTimePicker: fix prop warning for (#12933) ...
This was referenced Feb 4, 2019
This was referenced Feb 6, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Dismissible-notices: fix text overlapping icon (X) * Dismissible-notices: fix text overlapping icon (X) - pt.2.
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Dismissible-notices: fix text overlapping icon (X) * Dismissible-notices: fix text overlapping icon (X) - pt.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix of issue #11156 - added a margin on the right of dismissible notices.
How has this been tested?
I looked on the styles manually on left-to-right and right-to-left views.
Screenshots
Types of changes
Change in styles.
Checklist: