Make editor p tag "go with the flow". #12998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit sets the `p` tag to inherit whatever `font-size` and `line-height` are set on the `body` i.e., `.editor-styles-wrapper`. Currently the `p` tag here overrides a theme's most basic of font styles unless `font-size` and `line-height` are set on `p` in that theme. And from what I've seen, being that specific on `p` is an uncommon pattern. This also makes it easier and requires less specificity to style paragraphs on a per block basis by simply adding the font-size to the block container.
|
This should partly fix #11200, I think? |
|
Yep, I actually tried to find that ticket @chrisvanpatten but couldn't remember what it was exactly. Looking at it now, this wouldn't directly fix that issue. The Unless a |
|
Worth checking with themes not providing editor styles to see if it's correct. I remember that this was originally needed because Core used to styles for the paragraphs by default but maybe this inherit technique fix the issue. |
kjellr
approved these changes
Feb 7, 2019
This was referenced Feb 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
This commit sets the `p` tag to inherit whatever `font-size` and `line-height` are set on the `body` i.e., `.editor-styles-wrapper`. Currently the `p` tag here overrides a theme's most basic of font styles unless `font-size` and `line-height` are set on `p` in that theme. And from what I've seen, being that specific on `p` is an uncommon pattern. This also makes it easier and requires less specificity to style paragraphs on a per block basis by simply adding the font-size to the block container.
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
This commit sets the `p` tag to inherit whatever `font-size` and `line-height` are set on the `body` i.e., `.editor-styles-wrapper`. Currently the `p` tag here overrides a theme's most basic of font styles unless `font-size` and `line-height` are set on `p` in that theme. And from what I've seen, being that specific on `p` is an uncommon pattern. This also makes it easier and requires less specificity to style paragraphs on a per block basis by simply adding the font-size to the block container.
This was referenced Apr 30, 2020
This was referenced May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit sets the
ptag to inherit whateverfont-sizeandline-heightare set on thebodyi.e.,.editor-styles-wrapper.Currently the
ptag here overrides a theme's most basic of font styles unlessfont-sizeandline-heightare set onpin that theme.And from what I've seen, being that specific on
pis an uncommon pattern.This also makes it easier and requires less specificity to style paragraphs on a per block basis by simply adding the font-size to the block container.
How has this been tested?
I see no visual changes on a fresh underscores theme with demo content.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: