Skip to content

Conversation

Soean
Copy link
Member

@Soean Soean commented Oct 9, 2018

Description

Fixes some typos in tests and docs.

@Soean Soean added the [Type] Code Quality Issues or PRs that relate to code quality label Oct 9, 2018
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you for catching this typos @Soean!

@@ -69,7 +69,7 @@ const effects = {
const state = store.getState();

// Additional data needed for backwards compatibility.
// If we do not provide this data the post will be overriden with the default values.
// If we do not provide this data the post will be overridden with the default values.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we are changing this line maybe we can add also a comma:
If we do not provide this data, the post will be overridden with the default values.

@Soean Soean merged commit 471e581 into master Oct 9, 2018
@Soean Soean deleted the update/fix-some-typos branch October 9, 2018 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants