Add explicit button bottom margin for centered. #10470
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #7812, though in a somewhat heavy handed way. The issue is that many WordPress themes have this in their CSS files: ``` .aligncenter { margin: 0 auto; } ``` That zeroes out the bottom margin on a centered button block. If that style instead was: ``` .aligncenter { margin-left: auto; margin-right: auto; } ``` ... this would be a non issue. So the question becomes — do we increase the specificity of the centered button block margin rules to cover up years of bad practice? Or are we okay with centered buttons having no bottom margin in many older WordPress themes? Decide, then merge or don't ;)
tofumatt
requested changes
Oct 10, 2018
There was a problem hiding this comment.
I would argue for moving forward and leaving those old themes behind. I don't think it's worth adding this fix for old themes that won't update, personally…
Having to manage this style for years to come in new themes seems just as annoying 🤷♂️
I'd say we should close the original bug as a won't fix.
mtias
reviewed
Oct 10, 2018
| @@ -28,6 +28,7 @@ | |||
|
|
|||
| .editor-block-list__block[data-type="core/image"][data-align="center"] { | |||
| .wp-block-image { | |||
| clear: both; | |||
There was a problem hiding this comment.
Yes, forgot to mention this in the change notes.
The issue I was seeing was floating a small image left, then centering a small image after that. This would stack up next to the small floated image in the editor, but not the front-end. I did not dig deeper, but I can.
|
Closing based on feedback. We can always revisit if need be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7812, though in a somewhat heavy handed way.
The issue is that many WordPress themes have this in their CSS files:
That zeroes out the bottom margin on a centered button block.
If that style instead was:
... this would be a non issue.
So the question becomes — do we increase the specificity of the centered button block margin rules to cover up years of bad practice? Or are we okay with centered buttons having no bottom margin in many older WordPress themes?
Decide, then merge or don't ;)