Code Editor: unselect blocks and disable inserter #9815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofumatt
approved these changes
Sep 12, 2018
| return ( | ||
| <NavigableToolbar | ||
| className="edit-post-header-toolbar" | ||
| aria-label={ __( 'Editor Toolbar' ) } | ||
| > | ||
| <FullscreenModeClose /> | ||
| <div> | ||
| <Inserter position="bottom right" /> | ||
| <Inserter disabled={ mode !== 'visual' } position="bottom right" /> |
There was a problem hiding this comment.
These sorts of magic constants always irk me, even when they're strings. This is pretty obvious in its intent, but it's still possible to make typos, etc. 🤷♂️
Not really isolated to this PR though.
|
Yep! Ship it. This works well. |
|
@tofumatt Test added if you want to take another look. |
tofumatt
approved these changes
Sep 12, 2018
test/e2e/specs/code-editor.test.js
Outdated
| switchToEditor, | ||
| } from '../support/utils'; | ||
|
|
||
| describe( 'code editor', () => { |
There was a problem hiding this comment.
We have an editor-modes.test.js that this might fit into better, up to you though. Our test names are odd 🤷♂️
test/e2e/specs/code-editor.test.js
Outdated
|
|
||
| describe( 'code editor', () => { | ||
| beforeEach( async () => { | ||
| await await newPost(); |
… inserter disabled
75bdcf9 to
306ba2e
Compare
|
Yay, less is more! I'm glad we took this route to fix the parent issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9807
This PR does two things: