Skip to content

Fix left margin of Archives block #9347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented Aug 25, 2018

Description

Closes #9281

How has this been tested?

This has been tested with "npm test" and manually on Chrome

Screenshots

archives

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@@ -0,0 +1,3 @@
.gutenberg ul.wp-block-archives {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason why it is .gutenberg ul.wp-block-archives and not just .gutenberg .wp-block-archives?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is. The Archives block can be displayed as dropdown and the class '.wp-block-archives' is used for div element.

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Archives Block: Left margin doesn't match other list-based blocks.
3 participants