Dynamically add CSS classe to Paragraph block #71207
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -8 B (0%) Total Size: 1.91 MB
ℹ️ View Unchanged
|
3e56a26 to
f85fb8c
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
dmsnell
reviewed
Aug 14, 2025
| array( | ||
| 'render_callback' => 'block_core_paragraph_render', | ||
| ) | ||
| ); |
There was a problem hiding this comment.
by setting this as a render_callback we’re taking exclusive control over block rendering when all we’re doing is adding a class.
it may be more cooperative to implement the render_block_core/paragraph filter. that render_block interface will ruin us all 😄.
you can do the same thing using the filter but you won’t take an exclusive lock
There was a problem hiding this comment.
Thanks for the review! Sorry, there is still some disagreement on whether paragraph blocks need CSS classes or not. I would like to move this PR to draft until we reach a consensus 😅
|
Let's freeze this PR until the discussion in #47282 decides on a direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternatives to #47282
What?
This PR adds a block CSS class to the Paragraph block dynamically only.
Why?
We've been experimenting with adding a block CSS class to the Paragraph block, as we do to many other blocks. #47282 adds a CSS class to the saved block HTML itself, making it an irreversible change.
How?
Dynamically add a CSS class to the Paragraph block and change the global style selector from
pto.wp-block-paragraphonly if theIS_GUTENBERG_PLUGINconstant is defined and the value is true. This allows users to test the new behavior on sites that use the latest Gutenberg plugin. However, theclassNamesupport for the Paragraph block remains disabled, so the HTML saved to the database remains unchanged.If this change is favorable, we can gradually expand the scope of CSS classes as follows:
IS_GUTENBERG_PLUGINconstant checkclassName: falsefrom theblock.jsonso that the CSS classes are applied to the saved HTML as well.Testing Instructions
pelements don't havewp-block-paragraphCSS class.pelements havewp-block-paragraphCSS class.