Fix flaky 'navigable-toolbar' e2e test #71158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.91 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 0cce91b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16871211165
|
jeryj
approved these changes
Aug 11, 2025
|
Thanks, @jeryj! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #71134.
PR updates
can navigate to the block toolbar and back to the block using the keyboarde2e test to use native Playwright assertions instead of the customexpectLabelToHaveFocus. The former is more resilient to timing-based failures due to auto-retrying.P.S. I tried to move
expectLabelToHaveFocusfrom the test file, but there are other tests that fail for me locally due to various issues, while running successfully on GH.Testing Instructions
can navigate to the block toolbar and back to the block using the keyboardis passing without problems.