BrowserURL: Refactor to a function component and use hooks #71035
+74
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -113 B (-0.01%) Total Size: 1.91 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5c9b477. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16704000000
|
|
I just realized there's a similar PR by @R1shabh-Gupta. Considering this also refactors away from |
t-hamano
reviewed
Aug 6, 2025
There was a problem hiding this comment.
Thanks for the PR!
It works fine, but one concern is that the replaceState is executed on the first render, even though it already has the post ID:
b9ddfd8a5760ac1cab712f05d73f0b95.mp4
I don't think this will cause any problems, but do you think this needs to be resolved? My understanding is that this is related th the differencer in behaviour between class components and function components.
|
@t-hamano, yes, that's the difference between effect and lifecycle methods, which I don't think is a problem here. The main requirement is that client/server generated URLs should match, and they do. |
t-hamano
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Supersedes #70395.
PR refactors
BrowserURLinto a function component and replaces data HOCs with hooks.Why?
Just a minor code quality improvement.
Testing Instructions
Testing Instructions for Keyboard
Same.