Skip to content

Conversation

shail-mehta
Copy link
Member

@shail-mehta shail-mehta commented Aug 3, 2025

What? Why?

How?

  • Added @see tag after @deprecated tag in duotone.php

Testing Instructions

  1. Open duotone.php file
  2. See Documentation order

@shail-mehta shail-mehta self-assigned this Aug 3, 2025
@shail-mehta shail-mehta added the [Type] Developer Documentation Documentation for developers label Aug 3, 2025
@shail-mehta shail-mehta marked this pull request as ready for review August 3, 2025 05:12
Copy link

github-actions bot commented Aug 3, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta <shailu25@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shail-mehta shail-mehta changed the title Corrected Inline Documentation order in duotone file Updated Inline Documentation order in duotone file Aug 3, 2025
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

It may be better to use the @link tag instead of removing tags.

See the core code as a reference.

@Mamaduka
Copy link
Member

Mamaduka commented Aug 4, 2025

@t-hamano, I think PR just changes the property order.

@t-hamano
Copy link
Contributor

t-hamano commented Aug 5, 2025

instead of removing tags.

Ah, I wrote this by mistake 😅 However, rather than changing the order, I think it would be better to follow the core code and replace it with the @link tag.

@shail-mehta shail-mehta force-pushed the update/inline-documentation-order branch from 175a837 to cfa21a2 Compare August 5, 2025 16:06
@shail-mehta shail-mehta added the No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core label Aug 5, 2025
@shail-mehta
Copy link
Member Author

Updated PR as Per Above Comment.

@Mamaduka Mamaduka merged commit 1f7b5fc into trunk Aug 6, 2025
70 of 71 checks passed
@Mamaduka Mamaduka deleted the update/inline-documentation-order branch August 6, 2025 05:36
@github-actions github-actions bot added this to the Gutenberg 21.4 milestone Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants