Skip to content

CI: add workflow to check if there is a changelog entry for dataviews #71023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2025
Merged

CI: add workflow to check if there is a changelog entry for dataviews #71023

merged 1 commit into from
Aug 4, 2025

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Aug 1, 2025 •
edited
Loading

What?

This PR adds a check that fails if a PR touches code in packages/dataviews but doesn't add a changelog entry. There's a few exceptions (storybook, tests).

Why?

We want to be stricter in terms of what's documented in the Changelog.

How?

By creating a new workflow based on the existing check-components-changelog.yml.

Testing Instructions

@oandregal oandregal requested a review from desrosj as a code owner August 1, 2025 14:34
@oandregal oandregal self-assigned this Aug 1, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: oandregal <oandregal@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@oandregal oandregal added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Aug 1, 2025
This was referenced Aug 1, 2025
Closed
Closed
youknowriad
youknowriad approved these changes Aug 1, 2025
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this, I actually wonder if we can make this more generic for all packages :P or maybe a fixed set of packages: block-library, blocks, block-editor, components, dataviews and a few others. It's less important for edit-something packages.

@oandregal oandregal enabled auto-merge (squash) August 1, 2025 14:53
@Mamaduka
Copy link
Member

Mamaduka commented Aug 4, 2025

I love this, I actually wonder if we can make this more generic for all packages

+1 for generic and optional workflow. It will make it easier to maintain.

@oandregal oandregal mentioned this pull request Aug 4, 2025
Merged
@oandregal oandregal merged commit 0dbc7c3 into trunk Aug 4, 2025
65 of 67 checks passed
@oandregal oandregal deleted the update/checks-changelog-dataviews branch August 4, 2025 08:15
@github-actions github-actions bot added this to the Gutenberg 21.4 milestone Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@desrosj desrosj Awaiting requested review from desrosj desrosj is a code owner

Assignees

@oandregal oandregal

Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
Gutenberg 21.4
Development

Successfully merging this pull request may close these issues.
3 participants
@oandregal @Mamaduka @youknowriad