Skip to content

Add changelog entry for #70493. #71008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2025
Merged

Add changelog entry for #70493. #71008

merged 2 commits into from
Aug 1, 2025

Conversation

tellthemachines
Copy link
Contributor

What?

Closes

Follow-up from #70493 (comment).

I'm not sure whereabouts these changes might be added on a README. The only API update is the extra prop for mediaField.render, but field props don't seem to be documented anywhere. Might it be worth creating a section for them and adding them all in?

Copy link

github-actions bot commented Aug 1, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>
Co-authored-by: oandregal <oandregal@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Aug 1, 2025

Flaky tests detected in de79c06.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16665721802
📝 Reported issues:

@Mamaduka Mamaduka added the [Type] Developer Documentation Documentation for developers label Aug 1, 2025
@oandregal
Copy link
Member

@tellthemachines we have a section for the Field API, we could update the render method https://developer.wordpress.org/block-editor/reference-guides/packages/packages-dataviews/#render

@oandregal oandregal force-pushed the add/changelog-for-70493 branch from de79c06 to f5eaede Compare August 1, 2025 08:46
@oandregal
Copy link
Member

oandregal commented Aug 1, 2025

In the interest of making timezones work for us, I've pushed the changes to README (and rebased to fix some CI issues).

@oandregal oandregal merged commit 94af11b into trunk Aug 1, 2025
59 checks passed
@oandregal oandregal deleted the add/changelog-for-70493 branch August 1, 2025 09:27
@github-actions github-actions bot added this to the Gutenberg 21.4 milestone Aug 1, 2025
@tellthemachines
Copy link
Contributor Author

we have a section for the Field API

Oh I see! I was searching the docs for mediaField, no wonder I couldn't find it 😅

Thanks for fixing it up and merging André!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants