Editor: Move editor-sidebar CSS reset closer to its target #71096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -136 B (-0.01%) Total Size: 1.91 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
reviewed
Aug 6, 2025
| @@ -14,3 +14,7 @@ | |||
| .editor-post-summary .components-v-stack:empty { | |||
| display: none; | |||
| } | |||
|
|
|||
| .editor-sidebar { | |||
There was a problem hiding this comment.
Feels like we should be doing the same for all the other editor-* classnames that are now in the "edit-post" stylesheet no?
There was a problem hiding this comment.
Absolutely. I wanted to keep the PR as small as possible to drive the point. I'll move the others.
alshakero
commented
Aug 6, 2025
Comment on lines
-1
to
-18
| .editor-sidebar { | ||
| width: $sidebar-width; | ||
|
|
||
| > .components-panel { | ||
| border-left: 0; | ||
| border-right: 0; | ||
| margin-bottom: -1px; | ||
| margin-top: -1px; | ||
|
|
||
| > .components-panel__header { | ||
| background: $gray-100; | ||
| } | ||
| } | ||
|
|
||
| .block-editor-block-inspector__card { | ||
| margin: 0; | ||
| } | ||
| } |
There was a problem hiding this comment.
I checked these styles one by one. None of them are needed:
width: $sidebar-width;sets the same width 280px.border-left: 0; border-right: 0;are not needed because.components-panelhasborder: nonenow.margin-bottom: -1px; margin-top: -1px;are most likely a trick to collapse the double borders. But there is no border now because of the aforementionedborder: none.background: $gray-100;This one does change the background from the original#fff, to#f0f0f0, which I found a source of inconsistency.block-editor-block-inspector__card. There is no such element anymore.
|
@youknowriad I moved all the styles to their rightful owners. I tried to give the same treatment to |
youknowriad
approved these changes
Aug 6, 2025
|
Thanks for finding the root cause here :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The editor-sidebar children (such as
editor-post-panel__row-label) needbox-sizing: inherit (border-box)to look visually aligned. In most environments they get this CSS from the CSS reset of theedit-postpackage which is often used to render the editor, and all seems fine. But when the editor is rendered directly from@wordpress/editor, i.e withoutedit-postpackage, this reset is missing, and the sidebar items look misaligned as pictured.Why?
This moves the CSS reset to where it actually applies. Removing the need for the assumption that the editor will always run inside the
@wordpress/edit-postpackage.How?
But moving the reset from
edit-postto the editor itself.Testing Instructions
Status, try to findeditor-post-panel__row-label.box-sizing: inherit;.wp-content/plugins/gutenberg/build/editor/style.css?ver=21.3.0.trunk,gutenberg/build/edit-post/style.css?ver=21.3.0.Testing Instructions for Keyboard
Unrelated
Screenshots or screencast
N/A