Skip to content

Conversation

jasmussen
Copy link
Contributor

What?

Updates old table icons I found in the library to be the same optical footprint and design language as the other icons. Before and after:

Screenshot 2025-08-06 at 10 34 20

Same optical footprint, 1.5px stroke, same plus and cross icons.

Testing Instructions

npm run storybook:dev

Then observe the "table" prefixed icons:

image

@jasmussen jasmussen requested a review from a team August 6, 2025 08:45
@jasmussen jasmussen self-assigned this Aug 6, 2025
Copy link

github-actions bot commented Aug 6, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: karmatosed <karmatosed@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Aug 6, 2025

Flaky tests detected in c09737c.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16772061541
📝 Reported issues:

Copy link
Member

@karmatosed karmatosed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the icons, but there seems a test that is broken or not passing on this PR so that should be checked during merge.

@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Package] Icons /packages/icons labels Aug 6, 2025
@jasmussen
Copy link
Contributor Author

I see a green merge button :)

@t-hamano t-hamano merged commit 7147599 into trunk Aug 7, 2025
67 of 68 checks passed
@t-hamano t-hamano deleted the update/table-icons branch August 7, 2025 07:32
@github-actions github-actions bot added this to the Gutenberg 21.4 milestone Aug 7, 2025
@jasmussen
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Icons /packages/icons [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants