Skip to content

Conversation

jasmussen
Copy link
Contributor

What?

Small PR as I discovered in Storybook that the format-ltr and format-rtl icons are old and inconsistent with the new style. Here are updates and a before and after:

Screenshot 2025-08-06 at 10 19 27

Shown here, the Paragraph updated to be the same glyph as for the paragraph block, and the arrow indicating direction being a chevron like the other chevrons, instead of a sharp triangle.

Testing Instructions

npm run storybook:dev

then view format-ltr and format-rtl icons

@jasmussen jasmussen requested a review from a team August 6, 2025 08:24
@jasmussen jasmussen self-assigned this Aug 6, 2025
Copy link

github-actions bot commented Aug 6, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: karmatosed <karmatosed@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@karmatosed karmatosed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy approval 🙌🏻

@jasmussen
Copy link
Contributor Author

Nice, thank you. I guess this needs a changelog update? CC: @t-hamano we discussed this yesterday, I think the tentative heuristic was, that if it's just a small update like this that doesn't change the spirit of the icon, perhaps it doesn't need a changelog update?

@t-hamano
Copy link
Contributor

t-hamano commented Aug 6, 2025

As far as I know, there are no strict rules regarding changelog management, except for components packages and dataviews packages 😅

Personally, I think that for the icons package, we only need to document major changes such as adding new icons, removing icons, or deprecating icons.

@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Package] Icons /packages/icons labels Aug 6, 2025
@jasmussen
Copy link
Contributor Author

Thanks. Mind if I merge this one then?

@t-hamano
Copy link
Contributor

t-hamano commented Aug 6, 2025

🚢

@jasmussen jasmussen merged commit 74c71e2 into trunk Aug 6, 2025
67 of 68 checks passed
@jasmussen jasmussen deleted the update/ltr-icons branch August 6, 2025 12:31
@github-actions github-actions bot added this to the Gutenberg 21.4 milestone Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Icons /packages/icons [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants