Skip to content

Review all the 'Add New' strings #53984 #71083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lalitkumawat1m
Copy link
Contributor

What?

Closes #53984
Review all the 'Add New' strings #53984
Changed the inconsistent "add new " to "Add New ..."

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Before After

Copy link

github-actions bot commented Aug 6, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @xerpa43.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: xerpa43.

Co-authored-by: lalitkumawat1m <lalitkumawat@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: jamestitus299 <jamestitus299@git.wordpress.org>
Co-authored-by: alexstine <alexstine@git.wordpress.org>
Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Aug 6, 2025

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @lalitkumawat1m! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Aug 6, 2025
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended General Interface Parts of the UI which don't fall neatly under other labels. labels Aug 6, 2025
@Mamaduka
Copy link
Member

Mamaduka commented Aug 6, 2025

Thanks for working on this, @lalitkumawat1m!

Please see the latest feedback on the issue - #53984 (comment).

I think the string in packages/core-commands/src/admin-navigation-commands.js also needs an update to match current standards.

@Mamaduka
Copy link
Member

Mamaduka commented Aug 6, 2025

@lalitkumawat1m, it looks like this branch now contains some unrelated commits.

I would recommend checking the Code Contribution handbook for best practices to keep your branches up-to-date. See: https://developer.wordpress.org/block-editor/contributors/code/git-workflow

@lalitkumawat1m lalitkumawat1m force-pushed the update/review-all-the-strings branch from 2561030 to b37c9aa Compare August 6, 2025 12:05
@lalitkumawat1m lalitkumawat1m force-pushed the update/review-all-the-strings branch from c47d6dc to 7ee01d9 Compare August 6, 2025 13:05
@oandregal oandregal removed their request for review August 6, 2025 13:36
@Mamaduka Mamaduka self-requested a review August 6, 2025 14:30
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Thanks for contributing, @lalitkumawat1m!

@Mamaduka Mamaduka merged commit 2509cd7 into WordPress:trunk Aug 7, 2025
61 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.4 milestone Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review all the 'Add New' strings
2 participants