MediaReplaceFlow: Correctly truncate long URL #71062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -45 B (0%) Total Size: 1.91 MB
ℹ️ View Unchanged
|
|
@Mamaduka thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59807
Follow-up #57775
What?
Truncates a long media URL in the
MediaReplaceFlowcomponent.Why?
This URL is expected to be truncated by the
Truncatecomponent, but I noticed that the three dots were not displayed, and the buttons were pushed slightly to the right.How?
It seems that the
white-space: nowrapstyle of the parent element was affecting it, so I removed it. Furthermore,max-widthshould also be unnecessary. The innerTruncatecomponent should properly process text for both elements by default:gutenberg/packages/block-editor/src/components/link-control/link-preview.js
Lines 132 to 146 in 8470c8b
These two CSS elements should probably have been removed when the
Truncatecomponent was added in #57775.Testing Instructions
Use the following HTML to check the URL without an extension to be truncated correctly:
Screenshots or screencast
Before
After