Date Block: Ensure that fallback value is overridden if source is not registered #71047
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
If the block's
datetime
attribute is set, and it is bound to a Block Bindings source, ensure that the value received is indeed the one set by Block bindings -- i.e. that the fallback value is correctly overridden.Why?
Quoting WordPress/secure-custom-fields#206 (comment):
How?
By fixing the logic, based on an added assertion in the unit test to cover this scenario.
You can verify that the change is indeed needed to make tests pass by reverting it (e328014) and re-running tests.
Testing Instructions
Covered by automated tests.