-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Update dollar icon. #71042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dollar icon. #71042
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
4321292
to
287a230
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, much appreciated. Does this need a changelog update, you think? |
Regarding this package, I personally think that it is not necessary to update the changelog when fixing bugs. |
Agreed, thanks for the gut check. I'll merge when the checks pass! |
Curiously I don't have a green button I can press, the tooltip notes some missing merge requirements that I can't quite grok. If you have a green button on your end, feel free to press it. |
I can't press the button either. This is the first time I've seen this behavior. I've just submitted a PR that is equivalent to this PR. Let's confirm we can merge that PR instead. |
Thanks, let's see if the other one works. |
For some reason, this PR got the button working. It might have been a temporary GitHub problem. |
What?
Fixes regression reported in #70581 (comment).
How?
A copy paste mistake resulted in the dollar icon being replaced with a swatch icon. This PR corrects it.
Testing Instructions
Screenshots or screencast