Skip to content

Conversation

jasmussen
Copy link
Contributor

What?

Fixes regression reported in #70581 (comment).

How?

A copy paste mistake resulted in the dollar icon being replaced with a swatch icon. This PR corrects it.

Testing Instructions

  • npm run storybook:dev
  • Search for icons, choose library
  • Look at the dollar icon

Screenshots or screencast

image

@jasmussen jasmussen requested review from t-hamano and a team August 4, 2025 09:20
@jasmussen jasmussen self-assigned this Aug 4, 2025
@jasmussen jasmussen added [Type] Regression Related to a regression in the latest release [Package] Icons /packages/icons labels Aug 4, 2025
Copy link

github-actions bot commented Aug 4, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Before After
Image Image

P.S. It seemed that a conflict occurred because of icons package has been migrated to TypeScript. I resolved the conflict by changing the file extension from .js to .tsx and force-pushing it.

@jasmussen
Copy link
Contributor Author

Thank you, much appreciated. Does this need a changelog update, you think?

@t-hamano
Copy link
Contributor

t-hamano commented Aug 4, 2025

Does this need a changelog update, you think?

Regarding this package, I personally think that it is not necessary to update the changelog when fixing bugs.

@jasmussen
Copy link
Contributor Author

Agreed, thanks for the gut check. I'll merge when the checks pass!

@jasmussen
Copy link
Contributor Author

Curiously I don't have a green button I can press, the tooltip notes some missing merge requirements that I can't quite grok. If you have a green button on your end, feel free to press it.

@t-hamano
Copy link
Contributor

t-hamano commented Aug 4, 2025

I can't press the button either. This is the first time I've seen this behavior.

I've just submitted a PR that is equivalent to this PR. Let's confirm we can merge that PR instead.

#71044

@t-hamano t-hamano mentioned this pull request Aug 4, 2025
@jasmussen
Copy link
Contributor Author

Thanks, let's see if the other one works.

@t-hamano
Copy link
Contributor

t-hamano commented Aug 4, 2025

For some reason, this PR got the button working. It might have been a temporary GitHub problem.

@t-hamano t-hamano merged commit 919fe23 into trunk Aug 4, 2025
60 checks passed
@t-hamano t-hamano deleted the fix/dollar-icon branch August 4, 2025 11:16
@github-actions github-actions bot added this to the Gutenberg 21.4 milestone Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Icons /packages/icons [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants