TextControl: Improve theming support #70910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
commented
Jul 25, 2025
Comment on lines
+27
to
+28
| $components-color-dark-gray-placeholder: color-mix(in srgb, $components-color-foreground, transparent 38%); | ||
| $components-color-light-gray-placeholder: color-mix(in srgb, $components-color-background, transparent 35%); |
There was a problem hiding this comment.
Matches the CSS-in-JS equivalents:
gutenberg/packages/components/src/utils/colors-values.js
Lines 66 to 68 in a2cb1b0
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -200 B (-0.01%) Total Size: 1.89 MB
ℹ️ View Unchanged
|
jsnajdr
reviewed
Jul 28, 2025
| @@ -18,7 +18,12 @@ | |||
| margin: 0; | |||
| background: $components-color-background; | |||
| color: $components-color-foreground; | |||
| @include input-control( $components-color-accent); | |||
| @include input-control( $components-color-accent ); | |||
| border-color: $components-color-border; | |||
There was a problem hiding this comment.
Border color is already defined in the input-style__neutral mixin included by input-control. Should the themed color be moved to that mixin? Then it would apply to multiple components, everything that uses input-control. Not sure how big issue that is.
There was a problem hiding this comment.
The themed variables are experimental and live at the @wordpress/components level, so we don't want to expose them at the @wordpress/base-styles level.
|
|
||
| &::placeholder { | ||
| color: $components-color-dark-gray-placeholder; | ||
| } |
There was a problem hiding this comment.
Is there an existing style that styles the ::placeholder? I see some non-standard pseudo-selectors like ::-webkit-input-placeholder, I wonder why we don't use the standard one yet.
There was a problem hiding this comment.
I believe it's just old code and can be replaced. I guess the repo doesn't have the property-no-vendor-prefix lint?
adamsilverstein
pushed a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Jul 31, 2025
* TextControl: Improve theming support * Add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Makes the border and placeholder colors of
TextControlthemable.Why?
To expand themability of our basic components.
Testing Instructions
npm run storybook:devand go to the story forTextControl. Use the theme switcher in the top toolbar to try the dark theme.Screenshots or screencast