useSaveImage: handle missing editMediaEntity gracefully #70967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the retrieval of editMediaEntity to use optional chaining. - Added error handling to notify users when no edit media entity action is found during image editing.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +57 B (0%) Total Size: 1.89 MB
ℹ️ View Unchanged
|
Comment on lines
49
to
51
| __( | ||
| 'Could not edit image. No edit media entity action found.' | ||
| ), |
There was a problem hiding this comment.
In which cases will editMediaEntity not be available? Is there a more user-friendly error message we can provide? I'm mostly thinking that "edit media entity action" makes sense if you understand the internals of Gutenberg, but probably won't to an end user.
Otherwise, I like the idea of catching early and displaying an error notice!
There was a problem hiding this comment.
In which cases will editMediaEntity not be available?
When upload permissions aren't available on the user capabilities.
Maybe we could be upfront and describe the permissions fail like the backend does?
"Could not edit image. Sorry, you are not allowed to upload media on this site."
Or
"Could not edit image. Sorry, you are not allowed to edit media on this site."
There was a problem hiding this comment.
Yeah, I like that idea, any of those options sound fine to me. If we want to re-use a string that exists on the backend, there's also Sorry, you are not allowed to edit this item. which is slightly shorter. But I have no real preference other than using simple(ish) language 🙂
There was a problem hiding this comment.
The updated text looks good to me! Prettier is complaining now, though, I think it wants things on one line 😄
There was a problem hiding this comment.
Prettier! My arch enemy! Fixed
andrewserong
approved these changes
Jul 30, 2025
There was a problem hiding this comment.
LGTM too!
Also, thanks @Mamaduka — I just noticed that remove_cap persists in the database and was scratching my head for a second how to reset quickly 👍
|
Thanks for the helpful reviews @andrewserong and @Mamaduka 🙇🏻 |
adamsilverstein
pushed a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Jul 31, 2025
) Fix useSaveImage to handle missing editMediaEntity gracefully - Updated the retrieval of editMediaEntity to use optional chaining. - Added error handling to notify users when no edit media entity action is found during image editing. Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and how and why?
In #70814 a new private action
editMediaEntitywas added to Core Data. The action acts as an interface toWP_REST_Attachments_Controller RESTAPI'swp/v2/media/{ id }/edit route.editMediaEntityis only accessible in block editor settings if the user has upload permissions. This matches the backend's permission settings: https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php#L531Because some users might not have upload permissions, this PR adds a check to
editMediaEntityand optional chaining in the selector.If
editMediaEntityis not available, an error notification is shown.Shout out to @Mamaduka for the nudge
Testing Instructions
First, test that you can successfully crop and image as admin or editor.
Then remove your upload files permissions, e.g.,
Check that the error shows and nothing else borks.
Screenshots or screencast