Core Data: Add getTitle for user entity #70941
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @heavyweight! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
packages/core-data/src/entities.js
Outdated
| @@ -138,6 +138,7 @@ export const rootEntitiesConfig = [ | |||
| name: 'user', | |||
| kind: 'root', | |||
| baseURL: '/wp/v2/users', | |||
| getTitle: ( record ) => record?.username || record?.slug, | |||
There was a problem hiding this comment.
| getTitle: ( record ) => record?.username || record?.slug, | |
| getTitle: ( record ) => record?.name || record?.slug, |
This matches the user data displayed in the editor by different components.
Co-authored-by: heavyweight <kpapazov@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
What?
Closes
The title for edited users was not resolving correctly.
This lead to changes for user entities showing as untitled in the review changes modal.
This PR adds a mechanism for generating the title for users based on their username.
Why?
How?
Testing Instructions
npm run buildReview 1 change...showing at the bottom of the sidebarTesting Instructions for Keyboard
Screenshots or screencast