-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Sync package-lock.json on latest NPM #70839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: -630 B (-0.03%) Total Size: 1.89 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
On trunk, npm ci
fails (lockfile out of date). On this branch it works correctly with npm 10 and 11.
I'm surprised CI does not prevent getting into this state.
I opened #70844 as a potential improvement here. |
What?
Updates
package-lock.json
to commit changes caused ontrunk
when runningnpm install
with the latest version of npm (v11.4.2 at time of writing).Split from #70799
Why?
npm install
should not cause local changespackage-lock.json
should be kept in sync with the result ofnpm install
Testing Instructions
You can manually verify these changes are correct on trunk:
git checkout trunk
npm install -g npm@latest
npm install
git diff update/sync-package-lock