Allow add before/after on block toolbar menu dropdown when in write mode #70827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +14 B (0%) Total Size: 1.89 MB
ℹ️ View Unchanged
|
|
@jeryj, it looks like failing e2e tests are related to this change. |
It probably should just open up the Patterns Inserter, like the blue plus does (I'm ok with this being a follow-up/separate PR though): CleanShot.2025-07-22.at.08.36.57.mp4 |
richtabor
approved these changes
Jul 22, 2025
There was a problem hiding this comment.
Once the tests pass, this is good to go. We should follow-up with persisting the same functionality in zoom out (as detailed in #70827 (comment))
USERSATOSHI
pushed a commit
to USERSATOSHI/gutenberg
that referenced
this pull request
Jul 23, 2025
…ode (WordPress#70827) * Allow add before/after on block toolbar menu dropdown when in write mode * Update write-design-mode.spec.js --------- Co-authored-by: Rich Tabor <rich@tabor.email>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes
Allow the add before/after from the block settings dropdown in write mode.
Why?
You can press Enter on a block to access this behavior, so we may as well leave it in the block settings dropdown too.
How?
Replace the
! isContentOnlywith an! isZoomOutcheck, as we still don't want this behavior in zoom out. Ideally we would, but if we use it right now it places you in a paragraph block in zoom out mode, which shouldn't be allowed. We'll need an alternate behavior for this, such as opening the zoom out block inserter before/after and moving focus to it.Testing Instructions
Check that the content position and full height buttons are NOT available
Testing Instructions for Keyboard
Screenshots or screencast