Skip to content

Fields: Add label to Password field #70865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025
Merged

Conversation

t-hamano
Copy link
Contributor

What?

I noticed that the password field doesn't have a label and can't be translated.

Testing Instructions

Screenshots or screencast

Before After
image image

@t-hamano t-hamano self-assigned this Jul 23, 2025
@t-hamano t-hamano added Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Fields /packages/fields labels Jul 23, 2025
@t-hamano t-hamano requested review from Mamaduka and louwie17 July 23, 2025 09:44
@t-hamano t-hamano marked this pull request as ready for review July 23, 2025 09:44
Copy link

github-actions bot commented Jul 23, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added the [Type] Bug An existing feature does not function as intended label Jul 23, 2025
Copy link

Flaky tests detected in 995caac.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16467184986
📝 Reported issues:

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @t-hamano!

@Mamaduka Mamaduka merged commit bad82a0 into trunk Jul 24, 2025
69 of 74 checks passed
@Mamaduka Mamaduka deleted the dataview-password-field-label branch July 24, 2025 06:04
@github-actions github-actions bot added this to the Gutenberg 21.4 milestone Jul 24, 2025
adamsilverstein pushed a commit to adamsilverstein/gutenberg that referenced this pull request Jul 31, 2025
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Fields /packages/fields [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants