core-data: Try using cached permissions even when _fields is present in the query
#70738
+247
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_fields is present in the query_fields is present in the query
|
Size Change: +44 B (0%) Total Size: 1.89 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
approved these changes
Jul 16, 2025
|
Nice work, @priethor! This assumes that people always remember specifying Maybe |
Mamaduka
reviewed
Jul 16, 2025
|
I though |
The |
|
It seems |
Not exactly, calling it without |
Mamaduka
reviewed
Jul 16, 2025
Mamaduka
reviewed
Jul 17, 2025
Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
|
Flaky tests detected in 005e49d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16345188729
|
5 tasks
USERSATOSHI
pushed a commit
to USERSATOSHI/gutenberg
that referenced
this pull request
Jul 23, 2025
…t in the query (WordPress#70738) Co-authored-by: priethor <priethor@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Enhances
core-data's resolver to allow caching entity permissions if the data is available, even if the entity is not complete.Why?
Currently, when useEntityRecordsWithPermissions is called with a _fields parameter, permission caching is disabled. For example, if we optimize the post list experiment to only include the fields that are present in the view, this results in individual OPTIONS requests being made for each entity record to check permissions.
How?
By caching permissions from the
_links.targetHints.allowdata already present in the response, eliminating the need for separate OPTIONS requests when using_fields.Testing Instructions
_fieldsto the posts query #70744 and verify in the network console that it's firing one OPTIONS request per post in the tableScreenshots or screencast
Post list experiment currently:
When we optimize the post list experiment as in #70744, the size of the request with the posts query is much smaller, as it doesn't contain unnecessary data like all the posts' content, but we see an OPTIONS request per post:
Once we apply the changes to the resolver in this PR, we only see the original two requests plus a third one that fetches the selected post to preview it, without the options requests:
