List View: Delay block highlighting when moving the mouse over the items #70732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +16 B (0%) Total Size: 1.89 MB
ℹ️ View Unchanged
|
6 tasks
tyxla
reviewed
Jul 16, 2025
| @@ -97,6 +97,10 @@ function ListViewBlock( { | |||
| insertBeforeBlock, | |||
| setOpenedBlockSettingsMenu, | |||
| } = unlock( useDispatch( blockEditorStore ) ); | |||
| const debouncedToggleBlockHighlight = useDebounce( | |||
| toggleBlockHighlight, | |||
| 250 | |||
There was a problem hiding this comment.
Oh wow, 250 feels like a lot 😅:
Screen.Recording.2025-07-16.at.20.07.24.mov
I wonder if it makes sense to use a smaller debounce wait time, like 20 or 50. Would that be a better compromise
There was a problem hiding this comment.
Changed wait time to a 100. It feels more responsive now. Let me know if you would prefer a 50 delay.
Screencast
CleanShot.2025-07-17.at.07.22.18.mp4
There was a problem hiding this comment.
Yes, this is better, but IMO 50 hits the mark more effectively in terms of responsiveness and performance.
tyxla
approved these changes
Jul 17, 2025
|
Thanks for the review, @tyxla! I don't have a strong opinion here, so let's go with 50ms. |
USERSATOSHI
pushed a commit
to USERSATOSHI/gutenberg
that referenced
this pull request
Jul 23, 2025
…ems (WordPress#70732) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related #70666.
Similar to #44325.
PR adds a slight delay before highlighting the block on canvas when moving the mouse over the List View items.
Why?
Previously, moving the mouse was constantly dispatching Redux actions. Similar constant updates for the
block-editorstore can be pricey, as highlighted in #70666.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2025-07-15.at.16.52.12.mp4