Block Editor: Deprecate block hovered global state #70731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -22 B (0%) Total Size: 1.89 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ee0e2f4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16294048074
|
fabiankaegy
reviewed
Jul 15, 2025
packages/block-editor/src/components/block-list/use-block-props/use-is-hovered.js
Outdated
Show resolved
Hide resolved
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
talldan
reviewed
Jul 17, 2025
Comment on lines
2918
to
2920
| export function getHoveredBlockClientId( state ) { | ||
| return state.hoveredBlockClientId; | ||
| } |
There was a problem hiding this comment.
I'm in two minds about removing the action/selectors completely. Not sure if an option might be to have it return undefined and log a deprecation message. It at least prevents the editor from blowing up completely.
The action could do the same (not dispatch anything), though I'm not sure if an action returning undefined is an issue - would it be ignored?
There was a problem hiding this comment.
I was also hesitant about removing these vs deprecation. But here's why I decided to do so:
- The
https://wpdirectory.net/returns no results for them. - These actions/selectors shouldn't have been made public in the first case.
- The revert should've happened in Only show zoom out inserters on block selection #65759, but that ship has sailed :(
There was a problem hiding this comment.
@talldan, added changelog entry and marked this a breaking change.
There was a problem hiding this comment.
The https://wpdirectory.net/ returns no results for them.
I don't think this is completely exhaustive, which is why I'm hesitant about it. There's also plugins outside the repo and custom code added to individual sites that it doesn't cover.
I agree though, I can't imagine anyone using the APIs.
Alternative compromise could be to keep the functions with deprecations for a few releases, then follow up and remove them after a couple of plugin releases with the deprecation message active.
|
Thanks, @talldan! I restored the action/selector and added deprecation warnings; there's no need to risk breakage. We should be more careful when introducing new public APIs in the future. |
USERSATOSHI
pushed a commit
to USERSATOSHI/gutenberg
that referenced
this pull request
Jul 23, 2025
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR reverts block hovered global state from the block editor package, introduced in #63668.
Why?
Testing Instructions
is-hoveredstyle is correctly applied to the block wrapper. This can be checked via DevTools.Testing Instructions for Keyboard
Same.