Block Lock Modal: Add ul browser defaults CSS resets #70700
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -4 B (0%) Total Size: 1.89 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Jul 14, 2025
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks for the review!
For now, I'm not concerned about the font family because it's easier (and a little more common) to set that globally than the overrides for |
youknowriad
approved these changes
Jul 14, 2025
|
I'm going to merge this. Failing CI checks aren't related to this PR. See discussion in |
|
Thanks for merging! |
cbravobernal
pushed a commit
that referenced
this pull request
Jul 15, 2025
Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related to #70684 and a follow-on to #70685
Adds CSS resets for the
ulelement used in the block lock modal.Why?
To ensure that block editor components provide their own CSS resets, rather than depending on
common.css. Currently, the other instances ofulwithin the block editor package provide their own resets forlist-styleandpadding. The block lock modal is the only one in this package that doesn't (yet) do so.How?
For the CSS class used within the block lock modal, reset the list-style and padding (margin was already being reset).
Testing Instructions
common.cssrules:document.querySelector( 'link#common-css' ).remove()Testing Instructions for Keyboard
Screenshots or screencast