DataViews: Allow searching over array fieldtypes #70785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +22 B (0%) Total Size: 1.89 MB
ℹ️ View Unchanged
|
oandregal
reviewed
Jul 21, 2025
Searching over array fieldtypes with `enableGlobalSearch: true` threw a TypeError because the `normalizeSearchInput` function expected a string but received an array. This change fixes that by treating every value as an array and adapting the logic to match, before entering `normalizeSearchInput`.
This shows off that the search works over array fields too.
Also changed the second test so it's not just returning all results so it's clear that it is actually searching.
ca9f8e4 to
1dfdec6
Compare
|
Flaky tests detected in 46a8d4b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16464801606
|
oandregal
reviewed
Jul 23, 2025
| const { data: result } = filterSortAndPaginate( | ||
| data, | ||
| { | ||
| search: 'Moon', |
There was a problem hiding this comment.
title and description also have global search enabled, so this can give false positives because the 3 items (Europa, Io, Moon) have "moon" in the title or description. Perhaps change the search to Satellite?
… on title / description
|
Whoops, forgot to copy the props into the commit message 😬, sorry about that. |
|
Ah, I forgot to mention something: this needs a changelog update :) |
USERSATOSHI
pushed a commit
to USERSATOSHI/gutenberg
that referenced
this pull request
Jul 23, 2025
Searching over array fieldtypes with `enableGlobalSearch: true` threw a TypeError because the `normalizeSearchInput` function expected a string but received an array. This change fixes that by treating every value as an array and adapting the logic to match, before entering `normalizeSearchInput`.
dsas
added a commit
that referenced
this pull request
Jul 23, 2025
dsas
added a commit
that referenced
this pull request
Jul 24, 2025
adamsilverstein
pushed a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Jul 31, 2025
It was missed when merging WordPress#70785 originally. Co-authored-by: dsas <dsas@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #70782
Fixing a bug with searching over DataView fields that have the array field types.
Also updating the DataViews storybook to demonstrate that it works.
Why?
This fixes a bug with searching over DataView fields that have the array fieldtype. Previously they would crash with TypeError: input.trim is not a function
How?
Treats every value as an array before normalising and searching over every value in that array.
Testing Instructions
I've added some tests, to test manually:
Testing Instructions for Keyboard