Block API: Add attribute role-based filtering to 'isUnmodifiedBlock' #70764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +8 B (0%) Total Size: 1.89 MB
ℹ️ View Unchanged
|
|
Here's a patch for testing #70741 fix. diff --git packages/block-editor/src/store/actions.js packages/block-editor/src/store/actions.js
index 4f0ad81e312..57d0c7a8f6f 100644
--- packages/block-editor/src/store/actions.js
+++ packages/block-editor/src/store/actions.js
@@ -1254,7 +1254,14 @@ export const mergeBlocks =
}
if ( ! blockAType.merge ) {
- dispatch.selectBlock( blockA.clientId );
+ if ( isUnmodifiedBlock( blockB, 'content' ) ) {
+ dispatch.removeBlock(
+ clientIdB,
+ select.isBlockSelected( clientIdB )
+ );
+ } else {
+ dispatch.selectBlock( blockA.clientId );
+ }
return;
}ScreencastCleanShot.2025-07-17.at.19.09.44.mp4 |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
approved these changes
Jul 18, 2025
|
Thanks for the feedback, @t-hamano! |
USERSATOSHI
pushed a commit
to USERSATOSHI/gutenberg
that referenced
this pull request
Jul 23, 2025
…ordPress#70764) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
This was referenced Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related #70741 (comment).
PR introduces a new optional
roleparameter to theisUnmodifiedBlockandisUnmodifiedDefaultBlockfunctions, allowing for more granular checks of block attributes based on their roles.Why?
Currently, the block is considered unmodified when all of its attributes are equal to the defaults. While this is a reasonable assumption, there are instances when the block editor must determine whether the block's actual content has been changed.
See: #70741 (comment).
Testing Instructions
PR has unit test coverage.
Testing Instructions for Keyboard
Same.