Navigation Link: Fix URL deletion in Inspector Controls #70749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +63 B (0%) Total Size: 1.89 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7cf25a6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16364021649
|
d4d8bcb to
7cf25a6
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
fabiankaegy
approved these changes
Jul 18, 2025
|
Thanks for testing, @fabiankaegy! It appears that unit tests have started failing (#68143). I need to investigate this issue, and then I will merge the changes. |
Mamaduka
commented
Jul 18, 2025
Comment on lines
+239
to
+245
| // Defer the updateAttributes call to ensure entity connection isn't severed by accident. | ||
| updateAttributes( | ||
| { url: urlValue }, | ||
| { url: ! url ? lastURLRef.current : url }, | ||
| setAttributes, | ||
| attributes | ||
| { ...attributes, url: lastURLRef.current } | ||
| ); | ||
| setIsEditingControl( false ); |
There was a problem hiding this comment.
@getdave, what do you think about this?
The connection is severed after the first change on the trunk. This delays actual processing logic until the user is "done" editing, or if they have changed their mind.
There was a problem hiding this comment.
Good spot and I think we don't have much choice on this one.
I'm surprised we don't already just use internal state (useState) to manage the value and then only "submit" it on blur.
There was a problem hiding this comment.
This also works, so decided to go without separate internal state.
|
@fabiankaegy, @getdave, can I get a final approval? |
fabiankaegy
approved these changes
Jul 21, 2025
adamsilverstein
pushed a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Jul 21, 2025
) * Navigation Link: Fix URL deletion in Inspector Controls * Fix unit tests * Defer should sever entity link logic Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: Robertght <robertghetau@git.wordpress.org>
USERSATOSHI
pushed a commit
to USERSATOSHI/gutenberg
that referenced
this pull request
Jul 23, 2025
) * Navigation Link: Fix URL deletion in Inspector Controls * Fix unit tests * Defer should sever entity link logic Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: Robertght <robertghetau@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #60758.
PR fixes a bug for the Navigation Link control and allows deleting the last character in the URL control.
Why?
The user should be able to modify the URL entirely via the inspector controls.
How?
Reuse workaround for
labelcontrols.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2025-07-17.at.07.54.13.mp4