-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Post/Pages List: Add _fields
to the posts query
#70744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
priethor
wants to merge
2
commits into
trunk
Choose a base branch
from
add/dynamic-post-list-queries
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +152 B (+0.01%) Total Size: 1.89 MB
ℹ️ View Unchanged
|
948a605
to
6810068
Compare
Thanks, #70789 is a result of this exploration and needed for this PR to work properly, I've updated the description accordingly 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #70789
What?
Improves the pages/posts list performance by limiting the query to the fields that are needed.
Why?
To improve performance, as we avoid fetching unnecessary fields like the post content.
How?
Leveraging
_fields
in the posts query, including a minimum set of required fields plus those fields present in the current view.Testing Instructions
Screenshots or screencast
Before, the posts query fetches the default fields, including the post content, for all posts on the first page of the dataview

After, it will only fetch the required fields, plus an extra request to fetch the whole selected post to preview it:

Note:
Depends on #70738; until it lands, permissions are not properly cached, and there will be one extra OPTIONS request per post in the dataview to check permissions.