-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Correct padding for empty-state elements when <DataViews> is in a <Card> #70638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +46 B (0%) Total Size: 1.87 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense 👍
Flaky tests detected in efacdbf. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16132281554
|
What?
Follow up of #70567 where a number of changes were merged into the dataviews package.
One of the changes was tighter padding for
<DataViews>
when placed within a<Card>
. That change forgot to apply the tighter padding on the "no results" and "loading" elements that can exist within the dataview body too.Why?
We want consistent padding with dataviews so the elements always align nicely, even when the screen is small or the "no results" text is very long.
How?
Adds missing padding which should have been added in #70567.
No changelog entry is needed since it is covered by the existing one:
Testing Instructions
DataViews > With Card
storybookDataViews > Default
storybookTesting Instructions for Keyboard
Change only affects padding of static text.
Screenshots or screencast