Skip to content

Cover: fixed resetAll to return image resolution to default value #70608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

Cover: fixed resetAll to return image resolution to default value #70608

merged 1 commit into from
Jul 4, 2025
+1 −1

Conversation

shimotmk
Copy link
Contributor

@shimotmk shimotmk commented Jul 3, 2025

What?

Similar #70398 #70514

Why?

Clicking Reset all doesn't reset the resolution to default.
Fixed it to go back to full resolution like in #70398 #70514

How?

Testing Instructions

  1. Open a post or page.
  2. Insert Cover block and select a media file.
  3. Change its resolution.
  4. Confirm that it doesn't reset to the first available option.

Testing Instructions for Keyboard

Screenshots or screencast

Before

before.mp4

After

after.mp4

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shimotmk shimotmk changed the title Cover: fixed resetAll to return image resolution to default … Cover: fixed resetAll to return image resolution to default value Jul 3, 2025
t-hamano
t-hamano approved these changes Jul 4, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Block] Cover Affects the Cover Block - used to display content laid over a background image props-bot Adding this label triggers the Props Bot workflow for a PR. labels Jul 4, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jul 4, 2025
@t-hamano t-hamano merged commit 309338a into WordPress:trunk Jul 4, 2025
70 of 72 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.2 milestone Jul 4, 2025
@shimotmk shimotmk deleted the fix/cover/resetall-mesia-size branch July 4, 2025 10:26
@shimotmk shimotmk mentioned this pull request Jul 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees
No one assigned
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 21.2
Development

Successfully merging this pull request may close these issues.
2 participants
@shimotmk @t-hamano