Inserter: Fix focus style for disabled items #70691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The component also has styles for |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jasmussen
approved these changes
Jul 11, 2025
|
|
||
| &:not(:disabled) { | ||
| &:focus { | ||
| box-shadow: inset 0 0 0 var(--wp-admin-border-width-focus) var(--wp-admin-theme-color); |
There was a problem hiding this comment.
I'm seeing some new variable formats in SCSS, and some updated mixins. I wonder if we should employ a mixin for this while we're at it, perhaps block-toolbar-button-style__focus?
There was a problem hiding this comment.
I just tried, and it doesn't work for our case. The 'box-shadow' is cut off, just like on the trunk.
There was a problem hiding this comment.
Oh right, we need one that's inset only. Honestly it might be worth a new mixin. But no blockers.
|
Size Change: -3 B (0%) Total Size: 1.89 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 356907d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16218456024
|
cbravobernal
pushed a commit
that referenced
this pull request
Jul 15, 2025
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related #70663.
PR fixes focus styling for disabled items in the Inserter.
Why?
Items are still focusable when disabled; the focus styles should be applied correctly.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast