Skip to content

Media & Text: fixed resetAll to return image resolution to default value #70683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shimotmk
Copy link
Contributor

@shimotmk shimotmk commented Jul 10, 2025

What?

Similar #70398 #70514 #70608

Why?

Clicking Reset all doesn't reset the resolution to default.
Fixed it to go back to full resolution like in #70398 #70514 #70608

How?

Testing Instructions

  1. Open a post or page.
  2. Insert Media & Text block and select a media file.
  3. Change its resolution.
  4. Confirm that it doesn't reset to the first available option.

Testing Instructions for Keyboard

Screenshots or screencast

Before

after-media-text.mp4

After

before-media-text.mp4

Copy link

github-actions bot commented Jul 10, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Block] Media & Text Affects the Media & Text Block labels Jul 11, 2025
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-hamano t-hamano added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jul 11, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jul 11, 2025
@t-hamano t-hamano merged commit 9bd4dd1 into WordPress:trunk Jul 11, 2025
84 of 104 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.3 milestone Jul 11, 2025
@shimotmk shimotmk deleted the fix/media-text/reset-all-mesia-size branch July 11, 2025 09:57
cbravobernal pushed a commit that referenced this pull request Jul 15, 2025
…lue (#70683)

Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Media & Text Affects the Media & Text Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants