Video: Reuse logic for uploaded track selection #70675
Merged
+30
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @yogeshbhutkar! |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -23 B (0%) Total Size: 1.89 MB
ℹ️ View Unchanged
|
yogeshbhutkar
approved these changes
Jul 10, 2025
There was a problem hiding this comment.
The changes look solid on my end. Thanks for the follow-up 😅!
While testing, I noticed that this is one such place where the user might intend to upload multiple tracks at once. Even the menu label says "Add Tracks". Currently, multi-file upload/selection is not enabled; however, it's a straightforward implementation and could be a good follow-up.
|
Thanks for testing, @yogeshbhutkar! I think the "Add Tracks" is just a general label. Adding support for multiple track upload and selection could be a good enhancement; I'm not sure why it wasn't included when the feature was introduced. It might be worth checking the original PR #25861. I can follow up, unless you'd like to work on it. |
|
I'd like to take it up. I had it implemented in one of my experimental branches. I'd follow the discussions around it as well. Thanks! |
cbravobernal
pushed a commit
that referenced
this pull request
Jul 15, 2025
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR refactors Video block's track editor to reuse the same logic for uploaded track selection. This reduces code duplication.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast