iAPI Router: Preserve media attribute on initial style sheets after client-side navigation #70668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +7 B (0%) Total Size: 1.89 MB
ℹ️ View Unchanged
|
cbravobernal
pushed a commit
that referenced
this pull request
Jul 15, 2025
…ient-side navigation (#70668) * Add failing test * Add extra failing test * Only update mediaText when necessary * Update changelog -------- Co-authored-by: DAreRodz <darerodz@git.wordpress.org> Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
|
I just cherry-picked this PR to the release/21.2 branch to get it included in the next release: b0ef755 |
priethor
pushed a commit
that referenced
this pull request
Jul 15, 2025
…ient-side navigation (#70668) * Add failing test * Add extra failing test * Only update mediaText when necessary * Update changelog -------- Co-authored-by: DAreRodz <darerodz@git.wordpress.org> Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a bug with style sheets present on the initial page that have a specific
mediaattribute, e.g.,media="print". Themediaattribute in this case was overridden and unexpectedly set toall.How?
These changes make the style management logic update the
element.sheet.media.mediaTextproperty only when its value ispreload. For elements with any other value, the algorithm considers that the correct media value is already set.Testing Instructions
There are unit tests and e2e tests for this case.
It can also be tested by adding a
<style>element with amedia="print"attribute to the initial page and ensuring that those styles are not applied on the page after client-side navigation.