Fix: Font Library Modal: Focus outline not displaying correctly #70667
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Thanks for the PR!
We recommend not using CSS classname with .components- prefix as much as possible.
Fortunately, this button already has its own classname .font-library-modal__font-card. Therefore, we should be able to solve this problem by adding &:focus { position: relative; } here:
|
Hi @t-hamano , Thanks for the suggestion! I have made the update as recommended. Let me know if there's anything else you'd like me to adjust. |
* Enhance focus styles for buttons in font library modal * Refactor focus styles in font library modal Co-authored-by: prasadkarmalkar <prasadkarmalkar@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
What?
Closes #70656
Why?
Fixes Font Library Modal: Focus outline not displaying correctly
How?
Add the position property as relative for the font list item to make its outline visible.