Size Change: 0 B

Total Size: 1.89 MB

_{compressed-size-action}

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

What if a project already has a wp-cli.yml? Won't this destroy it?

What if a project already has a wp-cli.yml? Won't this destroy it?

Here in wp-env start we're creating a brand new WordPress project from scratch. How could a custom wp-cli.yml possibly get there? Is there something that I can put into a .wp-env.json file that creates the file?

But it's true that wp-env start --update will overwrite the existing file. That can be solved by writing the default config only when there is no existing wp-cli.yml. If someone has a custom one, it's their responsibility to add the needed apache_modules config. We don't need to do some complicated detection and patching.

Here in wp-env start we're creating a brand new WordPress project from scratch. How could a custom wp-cli.yml possibly get there?

@jsnajdr I'm not sure I understand. Running wp-env start is how the environment is started, not how a project is started from scratch. Whenever I start working on an existing project I get the environment fired up with npx wp-env start.

Running wp-env start is how the environment is started, not how a project is started from scratch.

The confusing part is that wp-env start doesn't just start the environment, it does three jobs:

1. create the environment from scratch if it doesn't exist yet
2. reconfigure/update the environment when config change is detected or when you pass the --update arg
3. finally start the environment

Jobs 1 and 3 are fine, the wp-cli.yml config is either not being written (start), or we are sure that none exists yet (create). It's only job 2 that is buggy, and I'm proposing a fix in #70661.

The whole logic can be figured out by tracking how the shouldConfigureWp variable is initialized and used.