Icons: Fix plusCircleFilled size #70650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.89 MB ℹ️ View Unchanged
|
|
Nice catch, I had completely forgotten those. This does fix the circle size. The ring-plus itself was 0.05 off in stroke width, however. I took a quick stab in the Figma file on addressing all these, and came to this; the before and after has the old circle plus, not the one you made which was 99% there: The new vectors, in case helpful: |
jasmussen
approved these changes
Jul 9, 2025
|
@jasmussen Thanks for the review! I'd like to merge this after updating the SVG path with the data you provide. |
cbravobernal
pushed a commit
that referenced
this pull request
Jul 15, 2025
* Icons: Fix plusCircleFilled size * Add changelog * Update path Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
This was referenced Jul 23, 2025
Merged
Closed
This was referenced Jul 28, 2025
Merged
Merged
fix(address-widget): use the correct
inputmode for the postal code field
myparcelnl/woocommerce#1375
Merged
Merged
This was referenced Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related to #70581
By changing the path size of the
plusCircleFilledicon from 40px to 32px, make it consistent with the other icons.Testing Instructions
Launch Storybook and access http://localhost:50240/?path=/story/icons-icon--library
Screenshots or screencast