ServerSideRender: Use data hooks instead of HoC #70529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -24 B (0%) Total Size: 1.86 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d980099. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/15897914343
|
There was a problem hiding this comment.
Pull Request Overview
Refactors the ExportedServerSideRender component to use useSelect and useMemo hooks instead of the withSelect higher-order component, streamlining the component tree and improving performance.
- Converted from HOC to function component with hooks
- Replaced
withSelectwithuseSelectfor fetchingcurrentPostId - Updated
urlQueryArgscomputation to useuseMemo
Comments suppressed due to low confidence (1)
packages/server-side-render/src/index.js:17
- Consider adding unit tests for
ExportedServerSideRenderto verify behavior whencurrentPostIdisnullversus a number, ensuring both branches of the URL args merging logic are covered.
export default function ExportedServerSideRender( {
| return EMPTY_OBJECT; | ||
| } )( ( { urlQueryArgs = EMPTY_OBJECT, currentPostId, ...props } ) => { | ||
| return postId && typeof postId === 'number' ? postId : null; | ||
| }, [] ); |
There was a problem hiding this comment.
Passing an empty dependency array to useSelect prevents it from updating when the editor store changes. Remove the [] so that useSelect re-runs on relevant store updates and keeps currentPostId in sync.
Suggested change
| }, [] ); | |
| } ); |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
This is incorrect 😄 An empty dependency array doesn't prevent useSelect from listening to the store updates.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
shubhtoy
pushed a commit
to shubhtoy/gutenberg
that referenced
this pull request
Jun 27, 2025
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR refactors
ExportedServerSideRendercomponent to use data hooks instead of HoCs.Why?
A micro-optimization reduces the size of the rendered component tree.
Testing Instructions