RawHTML: Clarify the wrapper 'div' element behavior #70527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.86 MB ℹ️ View Unchanged
|
gziolo
reviewed
Jun 26, 2025
| Component used as equivalent of Fragment with unescaped HTML, in cases where it is desirable to render dangerous HTML without needing a wrapper element. To preserve additional props, a `div` wrapper _will_ be created if any props aside from `children` are passed. | ||
| Component used to render unescaped HTML. | ||
|
|
||
| Note: The `renderElement` serializer will remove the `div` wrapper unless non-children props are present; typically when preparing a block for saving. |
There was a problem hiding this comment.
I'm not sure if that is clear enough. The way I understand it, there will be always a div wrapper. The only exception is when seralizing the block and there are no props provided, the content will be rendered as is.
There was a problem hiding this comment.
Maybe, we could also include an example with the result:
const Component = () => <RawHTML><h3>Hello world</h3></RawHTML>;
// Edit: <div><h3>Hello world</h3></div>
// save: <h3>Hello world</h3>There was a problem hiding this comment.
Yeah, tried my best not to sound too technical, and this is the best I could come up with 😅
I'll include code example 👍 Done in 1c5365b.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks for the feedback, @gziolo 🙇 |
shubhtoy
pushed a commit
to shubhtoy/gutenberg
that referenced
this pull request
Jun 27, 2025
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: USERSATOSHI <tusharbharti@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: philipjohn <philipjohn@git.wordpress.org>
|
Thank you @Mamaduka ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #70349
PR clarifies the wrapper
divbehavior inRawHTMLcomponent.Testing Instructions
None. It's just a documentation update.